mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.
Date Tue, 06 Dec 2016 02:33:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54336/#review158103
-----------------------------------------------------------




src/slave/constants.hpp 
<https://reviews.apache.org/r/54336/#comment228810>

    There isn't any need to get rid of this constant, but we could update the comment.
    
    i.e. This is the _desired_ default, but if the path is inaccessible (posix non-root),
the default will be a temporary folder.



src/slave/flags.cpp (lines 214 - 216)
<https://reviews.apache.org/r/54336/#comment228815>

    Seems like the problem on Windows is `os::user()` rather than the value of the `--runtime_dir`
flag.  As long as `os::user()` returns some value, we'll get an appropriate default runtime
directory for Windows.  In most cases, `/var/run/mesos` should work on Windows (unless there
are permission issues?), because our code does a recursive `mkdir` before using the runtime
directory.
    
    If this is the case, this review is probably the approach we want to take: https://reviews.apache.org/r/53706/


- Joseph Wu


On Dec. 5, 2016, 5:06 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54336/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2016, 5:06 p.m.)
> 
> 
> Review request for mesos and Alex Clemmer.
> 
> 
> Bugs: MESOS-6677
>     https://issues.apache.org/jira/browse/MESOS-6677
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit fixes MESOS-6677, which breaks the ability
> to run any agent on Windows, and thus is blocking all
> Windows development progress on the `master` branch.
> 
> The cause was that the default `runtime_dir` value was POSIX specific,
> and used `os::user()` which is deleted on Windows.
> The fix is to guard the POSIX code, and add a
> Windows implementation.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp 6c381f06365b9deb84f43cdd101a2d2e5d826f57 
>   src/slave/flags.cpp 0de15eca7da9bf8fbdbb90c6e96edfe76f4a0f44 
> 
> Diff: https://reviews.apache.org/r/54336/diff/
> 
> 
> Testing
> -------
> 
> make && make check on Linux: 1411 tests passed, no failures.
> 
> msbuild and attached to Linux master: no runtime failures.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message