mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 54295: Added a synchronous version of loop for io::read/write/redirect.
Date Tue, 06 Dec 2016 02:22:45 GMT


> On Dec. 6, 2016, 2:12 a.m., Benjamin Mahler wrote:
> > Is it possible to split the optional pid change from the discard logic change? If
so that would be great!
> > 
> > Looks like a chunk from the next patch slipped into this one?

Also, would be great to update the description to say that this also updates the discard logic
to resolve racing (and which race in particular).


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54295/#review158095
-----------------------------------------------------------


On Dec. 5, 2016, 4:35 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54295/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2016, 4:35 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a synchronous version of loop for io::read/write/redirect.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/loop.hpp a78ea7da8a5a778d816a64fb46d9479cc2a4ed70

>   3rdparty/libprocess/src/http.cpp fc55bda0fae8a43794fb938718b3a720dc342473 
>   3rdparty/libprocess/src/io.cpp e81f279ed4bf92f75ad2427550ca822a9b03cca5 
> 
> Diff: https://reviews.apache.org/r/54295/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message