mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 54395: Enabled build of Agent test harness on Windows.
Date Mon, 05 Dec 2016 22:06:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54395/
-----------------------------------------------------------

(Updated Dec. 5, 2016, 10:06 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.


Bugs: MESOS-6717
    https://issues.apache.org/jira/browse/MESOS-6717


Repository: mesos


Description
-------

This commit adds the Agent test harness to the Windows builds. This is
the first major step towards lighting up comprehensive Agent testing on
agent builds, an important step that has been prevented by a variety of
issues (e.g., things like getting the Master to work for at least
developer scenarios, and so on).

There is one important caveat to share here: the test harness will
currently error out immediately if you try to run it. In subsequent
reviews, we will add code that addresses these concerns directly, but
this is out of scope for the current review.


Diffs
-----

  src/CMakeLists.txt ea6e399c40d3b2cda195091dc7e74230ff3f68fd 
  src/tests/CMakeLists.txt 2ce9d37a75fdec3468aef8aba91db3a0a40e0220 
  src/tests/cluster.cpp 6a9d94b8ac3c8fd0428b7a67d1cb3f99a658fa9b 
  src/tests/test_helper_main.cpp a7d511ce71e2789df50aef02d2d50b4c94f38a50 

Diff: https://reviews.apache.org/r/54395/diff/


Testing
-------


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message