mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 53688: Implement a namespace/ipc isolator.
Date Mon, 05 Dec 2016 18:24:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53688/#review158022
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp (line 56)
<https://reviews.apache.org/r/53688/#comment228690>

    why 'pid-ipc'? should we be consistent, and calling it ipc-namespace-isolator?



src/tests/containerizer/isolator_tests.cpp (lines 81 - 105)
<https://reviews.apache.org/r/53688/#comment228691>

    Hum, I'd still suggest we inline those code in the test for now. I don't see a strong
reason we need to do that yet. 'executorCommand' here just check if the command succeeds or
not. We might want to check if a command 'failed' or not in the future. So let's don't do
this yet.
    
    The reason for that is that I found the test itself is more readable if all those logics
are self contained.



src/tests/containerizer/isolator_tests.cpp (line 108)
<https://reviews.apache.org/r/53688/#comment228693>

    This is nice. Let's keep this in the fixture.



src/tests/containerizer/isolator_tests.cpp (lines 138 - 142)
<https://reviews.apache.org/r/53688/#comment228692>

    If you want to do the refactor of the test fixture, you probably should update this test
as well. But as I mentioned above, let's not do it for now.



src/tests/containerizer/isolator_tests.cpp (lines 210 - 212)
<https://reviews.apache.org/r/53688/#comment228695>

    This is just a question. Looking at this test. I am wondering if you need to remount the
proc or not for IPC namespace?



src/tests/containerizer/isolator_tests.cpp (line 211)
<https://reviews.apache.org/r/53688/#comment228694>

    I'd use `stringify(shmmaxValue)` here


- Jie Yu


On Dec. 5, 2016, 5:29 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53688/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2016, 5:29 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-6557
>     https://issues.apache.org/jira/browse/MESOS-6557
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implement a namespace/ipc isolator.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ea6e399c40d3b2cda195091dc7e74230ff3f68fd 
>   src/Makefile.am 9177ea6a478620f97c692f9da4c92b475cae78cd 
>   src/slave/containerizer/mesos/containerizer.cpp a7e2665d4c64b7b322d4ae8d5441e8e777236c59

>   src/slave/containerizer/mesos/isolators/namespaces/ipc.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp PRE-CREATION 
>   src/tests/containerizer/isolator_tests.cpp da4627846730abd3a817c3d538ff5676c3c1ef45

> 
> Diff: https://reviews.apache.org/r/53688/diff/
> 
> 
> Testing
> -------
> 
> Make check on Fedora 24.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message