mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 54347: Cleaned up the 'IOSwitchboard.RedirectLog' test.
Date Mon, 05 Dec 2016 17:44:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54347/#review158018
-----------------------------------------------------------


Ship it!





src/tests/containerizer/io_switchboard_tests.cpp (line 239)
<https://reviews.apache.org/r/54347/#comment228673>

    Related to this, we need to fix the agent's `api/v1` handler default 'Accept' to be `application/json`
as it was before. Otherwise, an old client relying on it i.e., not setting the header would
break un-neccesarily after an upgrade.


- Anand Mazumdar


On Dec. 5, 2016, 7:09 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54347/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2016, 7:09 a.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Cleaned up the 'IOSwitchboard.RedirectLog' test.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/io_switchboard_tests.cpp ebf9bc75b8a256847a507954615241cff1da4dc3

> 
> Diff: https://reviews.apache.org/r/54347/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message