mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.
Date Mon, 05 Dec 2016 06:46:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45962/#review157765
-----------------------------------------------------------


Ship it!




I can take care of the addressing remaining minor comments.


src/examples/persistent_volume_framework.cpp (line 219)
<https://reviews.apache.org/r/45962/#comment228384>

    s/consumer/producer/.



src/examples/persistent_volume_framework.cpp (line 242)
<https://reviews.apache.org/r/45962/#comment228634>

    The empty line here doesn't comply with the [style guide](https://google.github.io/styleguide/cppguide.html#Loops_and_Switch_Statements).
Also for long blocks of switch case it looks better with `{}`.



src/examples/persistent_volume_framework.cpp (line 279)
<https://reviews.apache.org/r/45962/#comment228383>

    `)~");` should be aligned with `tasks` above but more usually we just put one the same
line where the string ends.



src/examples/persistent_volume_framework.cpp (line 431)
<https://reviews.apache.org/r/45962/#comment228633>

    s/and terminates/(terminated)/ since the last state is already TERMINATING.



src/examples/persistent_volume_framework.cpp (line 438)
<https://reviews.apache.org/r/45962/#comment228567>

    s/initialized/initial/



src/examples/persistent_volume_framework.cpp (line 439)
<https://reviews.apache.org/r/45962/#comment228632>

    Due to the change to add the INIT state, I think we have to revise this a bit:
    
    ```
    STAGING,     // The shard has started but haven't finished launching tasks.
    ```


- Jiang Yan Xu


On Dec. 2, 2016, 1:43 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45962/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2016, 1:43 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4431
>     https://issues.apache.org/jira/browse/MESOS-4431
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated a persistent volume test framework to include shared volumes.
> 
> 
> Diffs
> -----
> 
>   src/examples/persistent_volume_framework.cpp 9d45bb496c4cf378af429b5aa970bf81450e482a

> 
> Diff: https://reviews.apache.org/r/45962/diff/
> 
> 
> Testing
> -------
> 
> New test framework for shared resources added.
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message