mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Hindman <b...@berkeley.edu>
Subject Re: Review Request 54351: Allowed subprocess to take duplicated FDs.
Date Mon, 05 Dec 2016 05:01:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54351/#review157955
-----------------------------------------------------------


Ship it!




The changes all make sense, but I agree with Kevin that moving the "ownership" for Windows
into `internal::createChildProcess` would be more symetrical. Alternatively, could you move
the close out from `cloneChild` on Linux and do the closes immediately after you return from
both the Linux and Windows functions before you even check if the child creation was an error?

- Benjamin Hindman


On Dec. 5, 2016, 12:16 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54351/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2016, 12:16 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kevin Klues.
> 
> 
> Bugs: MESOS-6470
>     https://issues.apache.org/jira/browse/MESOS-6470
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allowed subprocess to take duplicated FDs.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/posix/subprocess.hpp aa4609d9e4c63f824c8cd631f39bbbe71e4f67b4

>   3rdparty/libprocess/include/process/windows/subprocess.hpp f452f6743d01f0b99010fa5e5bcbaae1358c8241

>   3rdparty/libprocess/src/subprocess.cpp 284e22e28ae8d2c1486e4a6bea743b8663ce2023 
> 
> Diff: https://reviews.apache.org/r/54351/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message