mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 54337: Fixed the attach input call validation on the agent.
Date Sat, 03 Dec 2016 19:19:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54337/
-----------------------------------------------------------

(Updated Dec. 3, 2016, 7:19 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Fixed the test to return `BadRequest`.


Repository: mesos


Description
-------

Previously, we were validating that all records on the stream
should have 'attach_container_input.container_id' set. However,
only the first record should have it set and be of type
'AttachContainerInput::CONTAINER_ID'.

This also raises the question if we should perform this 
validation in the handler itself for streaming requests.


Diffs (updated)
-----

  src/slave/http.cpp 8b104ce9ca6e72a1e76943f0d68a0541a45e39f6 
  src/slave/validation.cpp 15330ad6e63cf6adbdf36a3c1d1a60d2315ae511 
  src/tests/api_tests.cpp afae6a7e0809174f48f280f170fad9315e80a906 

Diff: https://reviews.apache.org/r/54337/diff/


Testing
-------

make check + added test


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message