mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 53688: Implement a namespace/ipc isolator.
Date Sat, 03 Dec 2016 03:58:30 GMT


> On Dec. 3, 2016, 1:28 a.m., Avinash sridharan wrote:
> > src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp, line 73
> > <https://reviews.apache.org/r/53688/diff/6/?file=1573535#file1573535line73>
> >
> >     Shouldn't containers (top-level containers) have the ability to specify if they
want an IPC namespace or not. Seems like the minute we turn on the IPC isolator we change
the default behavior of Mesos where every task/container starts getting a new IPC namespace
without it explicitly intending. 
> >     
> >     Was thinking, it might be better to introduce a flag in `MesosInfo` to explicitly
ask for an IPC namespace. This would maintain backward compatibility?

Do tasks get to choose whether they are in a PID namespace?


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53688/#review157875
-----------------------------------------------------------


On Dec. 2, 2016, 5:43 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53688/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2016, 5:43 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-6557
>     https://issues.apache.org/jira/browse/MESOS-6557
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implement a namespace/ipc isolator.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ea6e399c40d3b2cda195091dc7e74230ff3f68fd 
>   src/Makefile.am 7750ed756d60aa61225667c129df35c6ec70f239 
>   src/slave/containerizer/mesos/containerizer.cpp 7dde6fc7c20ecd3543891e7d33230d0eaf9460a2

>   src/slave/containerizer/mesos/isolators/namespaces/ipc.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp PRE-CREATION 
>   src/tests/containerizer/isolator_tests.cpp da4627846730abd3a817c3d538ff5676c3c1ef45

> 
> Diff: https://reviews.apache.org/r/53688/diff/
> 
> 
> Testing
> -------
> 
> Make check on Fedora 24.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message