mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 54198: Added Resource.Allocation in Offer.
Date Sat, 03 Dec 2016 02:22:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54198/#review157883
-----------------------------------------------------------


Ship it!





include/mesos/mesos.proto (lines 1325 - 1329)
<https://reviews.apache.org/r/54198/#comment228507>

    Let's add the same note to these as we did with the AllocationInfo inside Resource:
    
    ```
      // NOTE: Implementation of this is in-progress, DO NOT USE!
    ```


- Benjamin Mahler


On Dec. 2, 2016, 8:48 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54198/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2016, 8:48 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Qian Zhang.
> 
> 
> Bugs: MESOS-6634
>     https://issues.apache.org/jira/browse/MESOS-6634
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Resource.Allocation in Offer protobuf message to indicate a
> single role per offer. To preserve the offer semantics between a
> single multi-role scheduler and multiple single-role schedulers,
> we would like to ensure that an offer only contains resources
> allocated to a single role.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5981cb8357dc9ead141402aed82db81f8004b2cd 
>   include/mesos/v1/mesos.proto a560ed336c7fe4a745df11d3a6d753d5ff1d9b9c 
> 
> Diff: https://reviews.apache.org/r/54198/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message