mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 54324: Fixed switchboard build break on Windows.
Date Fri, 02 Dec 2016 23:44:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54324/#review157857
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On Dec. 2, 2016, 2:15 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54324/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2016, 2:15 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit will fix a build break on Windows 10, MSVC 1900, introduced
> dually by commits `bd1bd1eeee50dcb23d65dcadb4903822ffd88cfb` and
> `071ed5226be790aecd5ace1a7abda30b682078be`.
> 
> The recent additon of the I/O switchboard includes two things that break
> the Windows build. This commit will correct both of them.
> 
> First, `switchboard_main.cpp` references several constructs that are
> conditionally compiled out of the Windows build. One example is
> `IOSwitchboardServerFlags`. This was never supposed to be built on
> Windows, but it was accidentally added to the build, so this commit will
> simply remove it from the Windows build.
> 
> Second, the I/O switchboard changes introduced a new flag,
> `--io_switchboard_enable_server`, which is not implemented on Windows.
> When this change was submitted, this flag was accidentally conditionally
> not compiled on Windows builds, even though it is referenced in
> `switchboard.cpp` (since initialization of the switchboard is different
> when the server is not turned on). This commit will fix this issue by
> simply moving the `#ifdef` down so that the symbol is defined and used
> properly.
> 
> 
> Diffs
> -----
> 
>   cmake/MesosConfigure.cmake 9f747e9737accfcc66ac9d3b19d3ba6c7a125492 
>   src/slave/containerizer/mesos/CMakeLists.txt a7596f2d5318f65f59389e594fba914eea467126

>   src/slave/flags.hpp c6c3197bbf30ec617751f4a1a34914c0f0e29eb5 
> 
> Diff: https://reviews.apache.org/r/54324/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message