mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 54300: Added a test for validateRoles method.
Date Fri, 02 Dec 2016 22:17:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54300/#review157842
-----------------------------------------------------------




src/tests/master_validation_tests.cpp (lines 2366 - 2368)
<https://reviews.apache.org/r/54300/#comment228450>

    Just the first sentence here seems sufficient to me.



src/tests/master_validation_tests.cpp (lines 2371 - 2380)
<https://reviews.apache.org/r/54300/#comment228449>

    How about splitting each case with a block? As it stands its a bit hard to read what each
case is doing without the comments. For example:
    
    ```
      // Not MULTI_ROLE, no 'role' (defuaults to "*"), no 'roles'.
      {
        FrameworkInfo frameworkInfo;
        EXPECT_NONE(framework::internal::validateRoles(frameworkInfo));
      }
    
      // Not MULTI_ROLE, 'role' set, no 'roles'.
      {
        FrameworkInfo frameworkInfo;
        frameworkInfo.set_role("foo");
        EXPECT_NONE(framework::internal::validateRoles(frameworkInfo));
      }
    
      // MULTI_ROLE, 'role' set (error!), no 'roles'.
      {
        ...
      }
      
      ...
    ```


- Benjamin Mahler


On Dec. 2, 2016, 8:51 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54300/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2016, 8:51 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Guangya Liu.
> 
> 
> Bugs: MESOS-6629
>     https://issues.apache.org/jira/browse/MESOS-6629
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> There are three attributes: 'role', 'roles' and MULTI_ROLE to be
> validated by this method, therefore covered by 2^3 test cases.
> Also the test ensures this method checks duplicate entries in 'roles'.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_validation_tests.cpp 5c44967a077551944831383a6bcc6dcb1c626df9 
> 
> Diff: https://reviews.apache.org/r/54300/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message