mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 54262: Added macOS 10.12 instructions to the getting started page.
Date Fri, 02 Dec 2016 20:15:08 GMT


> On Dec. 2, 2016, 5:51 p.m., James Peach wrote:
> > docs/getting-started.md, line 98
> > <https://reviews.apache.org/r/54262/diff/1/?file=1574307#file1574307line98>
> >
> >     I would do:
> >     ```
> >     --with-apr=$(brew --prefix apr)/libexec
> >     --with-svn=$(brew --prefix subversion)
> >     ```

It looks like with Michael's patches I probably just take the `--with-apr` and `--with-svn`
out. It turns out we already look for brew's subversion when handling `--with-svn` but we
didn't look for brew's subversion when handling `--with-apr`.

See: https://reviews.apache.org/r/54280/


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54262/#review157770
-----------------------------------------------------------


On Dec. 1, 2016, 8:49 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54262/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2016, 8:49 p.m.)
> 
> 
> Review request for mesos, Jie Yu and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> There are several issues building on macOS 10.12 that should
> be documented for users.
> 
> 
> Diffs
> -----
> 
>   docs/getting-started.md 3c0fec6d15e0c2e5be85e9d482465b6008729ee0 
> 
> Diff: https://reviews.apache.org/r/54262/diff/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message