mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 54291: Added os::ptsname to stout.
Date Fri, 02 Dec 2016 09:16:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54291/#review157711
-----------------------------------------------------------




3rdparty/stout/include/stout/posix/os.hpp (line 480)
<https://reviews.apache.org/r/54291/#comment228328>

    We should be able to use a simple function-local static here and avoid the global leak
of `mutex`, e.g.,
    
        static std::mutex mutex;



3rdparty/stout/include/stout/posix/os.hpp (line 483)
<https://reviews.apache.org/r/54291/#comment228329>

    We can use a `const char*` here as we wouldn't want to modify the returned value.


- Benjamin Bannier


On Dec. 2, 2016, 7:42 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54291/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2016, 7:42 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added os::ptsname to stout.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/posix/os.hpp c37e64db662ba3cee83d2f55de0f9d71ad72c038

> 
> Diff: https://reviews.apache.org/r/54291/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message