mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.
Date Thu, 01 Dec 2016 22:38:15 GMT


> On Dec. 1, 2016, 9:29 p.m., Greg Mann wrote:
> > src/examples/persistent_volume_framework.cpp, lines 427-430
> > <https://reviews.apache.org/r/45962/diff/23/?file=1571558#file1571558line427>
> >
> >     Could you provide comments here or elsewhere which give a high-level overview
of the state machine's strategy. i.e., first we launch a "writer task" that touches a file,
then we use "reader tasks" to verify volume functionality.

Added a comment on the flow of the state machine in `PersistentVolumeScheduler::resourceOffers()`
[where the state machine is initiated and managed].


- Anindya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45962/#review157642
-----------------------------------------------------------


On Nov. 29, 2016, 12:25 a.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45962/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 12:25 a.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4431
>     https://issues.apache.org/jira/browse/MESOS-4431
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated a persistent volume test framework to include shared volumes.
> 
> 
> Diffs
> -----
> 
>   src/examples/persistent_volume_framework.cpp 9d45bb496c4cf378af429b5aa970bf81450e482a

> 
> Diff: https://reviews.apache.org/r/45962/diff/
> 
> 
> Testing
> -------
> 
> New test framework for shared resources added.
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message