mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.
Date Thu, 01 Dec 2016 21:29:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45962/#review157642
-----------------------------------------------------------


Fix it, then Ship it!





src/examples/persistent_volume_framework.cpp (lines 121 - 127)
<https://reviews.apache.org/r/45962/#comment228269>

    s/slave/agent



src/examples/persistent_volume_framework.cpp (line 275)
<https://reviews.apache.org/r/45962/#comment228273>

    This is unnecessary since we're in the `case` block for `Shard::STAGING` already.



src/examples/persistent_volume_framework.cpp (lines 412 - 415)
<https://reviews.apache.org/r/45962/#comment228280>

    Could you provide comments here or elsewhere which give a high-level overview of the state
machine's strategy. i.e., first we launch a "writer task" that touches a file, then we use
"reader tasks" to verify volume functionality.



src/examples/persistent_volume_framework.cpp (lines 483 - 489)
<https://reviews.apache.org/r/45962/#comment228282>

    I would suggest that we should run this test framework in the test suite with both regular
and shared persistent volumes. We could:
    1) Do a single run of the test framework which uses both shared and regular volumes
    2) Do a couple different runs of the test framework which each use different types of
volumes.
    
    This could be accomplished either here in the default flag values, or by altering the
test run script to pass flags in.
    
    Thoughts?


- Greg Mann


On Nov. 29, 2016, 12:25 a.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45962/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 12:25 a.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4431
>     https://issues.apache.org/jira/browse/MESOS-4431
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated a persistent volume test framework to include shared volumes.
> 
> 
> Diffs
> -----
> 
>   src/examples/persistent_volume_framework.cpp 9d45bb496c4cf378af429b5aa970bf81450e482a

> 
> Diff: https://reviews.apache.org/r/45962/diff/
> 
> 
> Testing
> -------
> 
> New test framework for shared resources added.
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message