mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 54196: Added API handler for LAUNCH_NESTED_CONTAINER_SESSION.
Date Thu, 01 Dec 2016 06:46:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54196/
-----------------------------------------------------------

(Updated Dec. 1, 2016, 6:46 a.m.)


Review request for mesos and Anand Mazumdar.


Changes
-------

updated for signature change.


Bugs: MESOS-6471
    https://issues.apache.org/jira/browse/MESOS-6471


Repository: mesos


Description
-------

In addition to launching the nested container the API handler
ensures that the container is destroyed if the connection breaks.


Diffs (updated)
-----

  src/slave/http.cpp 87189dd6e2e099cb74faabd3ad26aaca11e5cef2 
  src/slave/slave.hpp 05865a09724f7a46e9c06b02e59779513fc532aa 
  src/slave/validation.cpp 46e84361244394196ee5d431c1da34686d6c938a 
  src/tests/api_tests.cpp b2a70f3174824d3cb241a098d96e4d63a390f8bc 

Diff: https://reviews.apache.org/r/54196/diff/


Testing
-------

make check

Added a basic test for now that tests the failure case. Will be adding more tests in subsequent
reviews.


Thanks,

Vinod Kone


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message