mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 54197: Introduced Resource.AllocationInfo.
Date Thu, 01 Dec 2016 01:10:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54197/#review157519
-----------------------------------------------------------


Fix it, then Ship it!




There is a typo in `Description` section: s/This if/This is


include/mesos/mesos.proto (lines 787 - 793)
<https://reviews.apache.org/r/54197/#comment228143>

    How about the following to make it less jagged?
    
    ```
      message AllocationInfo {
        // If set, this resource is allocated to a role. Note that in the
        // future, this may be unset and the scheduler may be responsible
        // for allocating to one of its roles.
        optional string role = 1;
    
        // In the future, we may add additional fields here, e.g. priority
        // tier, type of allocation (quota / fair share).
      }
    ```


- Guangya Liu


On 十一月 30, 2016, 9:58 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54197/
> -----------------------------------------------------------
> 
> (Updated 十一月 30, 2016, 9:58 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Qiang Zhang.
> 
> 
> Bugs: MESOS-6633
>     https://issues.apache.org/jira/browse/MESOS-6633
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To determine which role resources are allocated to, we now need to
> store allocation information within the Resources. This if part of
> the effort to support multi-role frameworks. See MESOS-6633 for more
> details.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto cbfcd8a666e0b4a486f6dcd9e8356c9d5a1cea05 
>   include/mesos/v1/mesos.proto e4f269b96ffc06d040604d1d6fead01e4aca2c13 
> 
> Diff: https://reviews.apache.org/r/54197/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message