mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 54148: Updated the io switchboard to launch an external io switchboard server.
Date Thu, 01 Dec 2016 00:54:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54148/
-----------------------------------------------------------

(Updated Dec. 1, 2016, 12:54 a.m.)


Review request for mesos and Jie Yu.


Changes
-------

Updated based on Jie's comments.


Bugs: MESOS-6639
    https://issues.apache.org/jira/browse/MESOS-6639


Repository: mesos


Description
-------

We don't currently handle recovering access to the io switchboard
server process after agent restarts. We will add that in a subsequent
commit.


Diffs (updated)
-----

  src/Makefile.am 7750ed756d60aa61225667c129df35c6ec70f239 
  src/slave/containerizer/mesos/io/switchboard.hpp d3ab52d98ade067ccec63f3539073c152840099f

  src/slave/containerizer/mesos/io/switchboard.cpp ae7a1fe3e24d5dc18269d9da951493700ee957d0

  src/slave/containerizer/mesos/io/switchboard_main.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/54148/diff/


Testing
-------

GTEST_FILTER="" make -j check
sudo src/mesos-tests

[  FAILED  ] bool/UserContainerLoggerTest.ROOT_LOGROTATE_RotateWithSwitchUserTrueOrFalse/0,
where GetParam() = true


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message