mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 53974: Added support to handle ATTACH_CONTAINER_OUPUT in the io switchbaord.
Date Thu, 01 Dec 2016 00:23:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53974/#review157498
-----------------------------------------------------------




src/slave/containerizer/mesos/io/switchboard.cpp (line 509)
<https://reviews.apache.org/r/53974/#comment228101>

    This can be Option<Failure> failure.



src/slave/containerizer/mesos/io/switchboard.cpp (lines 654 - 663)
<https://reviews.apache.org/r/53974/#comment228124>

    we should handle onDiscarded as well



src/slave/containerizer/mesos/io/switchboard.cpp (line 655)
<https://reviews.apache.org/r/53974/#comment228102>

    `failure = Failure("Failed ...");`



src/slave/containerizer/mesos/io/switchboard.cpp (line 656)
<https://reviews.apache.org/r/53974/#comment228103>

    Can you add some notes about why 'false' is used here?



src/slave/containerizer/mesos/io/switchboard.cpp (line 680)
<https://reviews.apache.org/r/53974/#comment228104>

    `{` on the next line.



src/slave/containerizer/mesos/io/switchboard.cpp (line 739)
<https://reviews.apache.org/r/53974/#comment228105>

    kill this line?



src/slave/containerizer/mesos/io/switchboard.cpp (line 746)
<https://reviews.apache.org/r/53974/#comment228106>

    kill this line



src/slave/containerizer/mesos/io/switchboard.cpp (line 787)
<https://reviews.apache.org/r/53974/#comment228113>

    const?



src/slave/containerizer/mesos/io/switchboard.cpp (line 796)
<https://reviews.apache.org/r/53974/#comment228112>

    why not const?



src/slave/containerizer/mesos/io/switchboard.cpp (line 825)
<https://reviews.apache.org/r/53974/#comment228117>

    iterator might be invalidated after insertion or erase. So I don't think this works.



src/tests/containerizer/io_switchboard_tests.cpp (line 204)
<https://reviews.apache.org/r/53974/#comment228129>

    Is there constant for this?


- Jie Yu


On Nov. 30, 2016, 10:26 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53974/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2016, 10:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-6467
>     https://issues.apache.org/jira/browse/MESOS-6467
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support to handle ATTACH_CONTAINER_OUPUT in the io switchbaord.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.hpp aaa3a35245b291f6003f519dbf8c0e1b82bc15fd

>   src/slave/containerizer/mesos/io/switchboard.cpp 25cbf2447d197134f0753b062b6f4130821005b2

>   src/slave/containerizer/mesos/io/switchboard_main.cpp PRE-CREATION 
>   src/tests/containerizer/io_switchboard_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53974/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER="" make -j check
> sudo src/mesos-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message