-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53949/#review156860
-----------------------------------------------------------




src/tests/utils.hpp (line 77)
<https://reviews.apache.org/r/53949/#comment227183>

    Capitalize "while".



src/tests/utils.hpp (line 80)
<https://reviews.apache.org/r/53949/#comment227191>

    #include <cstdint>



src/tests/utils.cpp (lines 73 - 74)
<https://reviews.apache.org/r/53949/#comment227189>

    We definitely need to say that our assumption is that socket implementation closes the socket on destruction.


- Alexander Rukletsov


On Nov. 22, 2016, 3:49 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53949/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2016, 3:49 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and haosdent huang.
> 
> 
> Bugs: MESOS-6618
>     https://issues.apache.org/jira/browse/MESOS-6618
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test helper to obtain unused port.
> 
> 
> Diffs
> -----
> 
>   src/tests/utils.hpp 140ebaaae43b03568ec49891635f0660cdfb4c85 
>   src/tests/utils.cpp eb36616f68d81d33d4bd04a7f23295e8c7558fc8 
> 
> Diff: https://reviews.apache.org/r/53949/diff/
> 
> 
> Testing
> -------
> 
> Tested as part of https://reviews.apache.org/r/53950/.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>