From reviews-return-50902-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Nov 24 17:34:31 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E3F0E1933A for ; Thu, 24 Nov 2016 17:34:30 +0000 (UTC) Received: (qmail 47955 invoked by uid 500); 24 Nov 2016 17:34:30 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 47931 invoked by uid 500); 24 Nov 2016 17:34:30 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 47911 invoked by uid 99); 24 Nov 2016 17:34:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Nov 2016 17:34:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CBAA12F6690; Thu, 24 Nov 2016 17:34:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1079079186831678376==" MIME-Version: 1.0 Subject: Re: Review Request 53949: Added test helper to obtain unused port. From: Alexander Rukletsov To: haosdent huang , Alexander Rukletsov Cc: Benjamin Bannier , mesos Date: Thu, 24 Nov 2016 17:34:28 -0000 Message-ID: <20161124173428.27388.10602@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexander Rukletsov X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53949/ X-Sender: Alexander Rukletsov References: <20161122154954.27388.94334@reviews.apache.org> In-Reply-To: <20161122154954.27388.94334@reviews.apache.org> Reply-To: Alexander Rukletsov X-ReviewRequest-Repository: mesos --===============1079079186831678376== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53949/#review156860 ----------------------------------------------------------- src/tests/utils.hpp (line 77) Capitalize "while". src/tests/utils.hpp (line 80) #include src/tests/utils.cpp (lines 73 - 74) We definitely need to say that our assumption is that socket implementation closes the socket on destruction. - Alexander Rukletsov On Nov. 22, 2016, 3:49 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53949/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2016, 3:49 p.m.) > > > Review request for mesos, Alexander Rukletsov and haosdent huang. > > > Bugs: MESOS-6618 > https://issues.apache.org/jira/browse/MESOS-6618 > > > Repository: mesos > > > Description > ------- > > Added test helper to obtain unused port. > > > Diffs > ----- > > src/tests/utils.hpp 140ebaaae43b03568ec49891635f0660cdfb4c85 > src/tests/utils.cpp eb36616f68d81d33d4bd04a7f23295e8c7558fc8 > > Diff: https://reviews.apache.org/r/53949/diff/ > > > Testing > ------- > > Tested as part of https://reviews.apache.org/r/53950/. > > > Thanks, > > Benjamin Bannier > > --===============1079079186831678376==--