From reviews-return-50742-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Nov 23 01:07:01 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2136F19032 for ; Wed, 23 Nov 2016 01:07:01 +0000 (UTC) Received: (qmail 37164 invoked by uid 500); 23 Nov 2016 01:07:01 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 37134 invoked by uid 500); 23 Nov 2016 01:07:01 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 37112 invoked by uid 99); 23 Nov 2016 01:07:00 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Nov 2016 01:07:00 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5F40C2F5B78; Wed, 23 Nov 2016 01:06:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2115029468417829759==" MIME-Version: 1.0 Subject: Re: Review Request 52871: Ensured default executor ignores health updates for terminated tasks. From: Alexander Rukletsov To: Anand Mazumdar , =?utf-8?q?Gast=C3=B3n_Kleiman?= , Benjamin Mahler , haosdent huang Cc: Alexander Rukletsov , mesos Date: Wed, 23 Nov 2016 01:06:59 -0000 Message-ID: <20161123010659.27388.80201@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexander Rukletsov X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/52871/ X-Sender: Alexander Rukletsov References: <20161123005009.27388.15418@reviews.apache.org> In-Reply-To: <20161123005009.27388.15418@reviews.apache.org> Reply-To: Alexander Rukletsov X-ReviewRequest-Repository: mesos --===============2115029468417829759== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52871/ ----------------------------------------------------------- (Updated Nov. 23, 2016, 1:06 a.m.) Review request for mesos, Anand Mazumdar, Benjamin Mahler, Gastón Kleiman, and haosdent huang. Bugs: MESOS-5963 https://issues.apache.org/jira/browse/MESOS-5963 Repository: mesos Description ------- After the task has been terminated, its health updates become irrelevant and should be ignored. Also if the default executor shuts down, we can safely stop all health checkers. Technically health checking should be stopped right before TASK_KILLING update is sent to avoid subsequent TASK_RUNNING updates, but the default executor currently does not support TASK_KILLING. Diffs (updated) ----- src/launcher/default_executor.cpp f4e1ea4816fee9a2f6d59bb534933b66013f11cf Diff: https://reviews.apache.org/r/52871/diff/ Testing ------- See https://reviews.apache.org/r/52873/. Thanks, Alexander Rukletsov --===============2115029468417829759==--