From reviews-return-50700-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Nov 22 20:58:03 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3652119527 for ; Tue, 22 Nov 2016 20:58:03 +0000 (UTC) Received: (qmail 74209 invoked by uid 500); 22 Nov 2016 20:58:03 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 74181 invoked by uid 500); 22 Nov 2016 20:58:03 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 74163 invoked by uid 99); 22 Nov 2016 20:58:02 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Nov 2016 20:58:02 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 76E982F5ABF; Tue, 22 Nov 2016 20:58:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6641543330043630843==" MIME-Version: 1.0 Subject: Re: Review Request 53991: Added master API call for `UPDATE_QUOTA`. From: Mesos ReviewBot To: Xiaojian Huang , Alexander Rukletsov Cc: Zhitao Li , Mesos ReviewBot , mesos Date: Tue, 22 Nov 2016 20:58:01 -0000 Message-ID: <20161122205801.27388.61887@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos ReviewBot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53991/ X-Sender: Mesos ReviewBot References: <20161122183147.27388.65162@reviews.apache.org> In-Reply-To: <20161122183147.27388.65162@reviews.apache.org> Reply-To: Mesos ReviewBot X-ReviewRequest-Repository: mesos --===============6641543330043630843== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53991/#review156628 ----------------------------------------------------------- Patch looks great! Reviews applied: [52284, 53679, 53691, 52103, 53991] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Nov. 22, 2016, 6:31 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53991/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2016, 6:31 p.m.) > > > Review request for mesos, Alexander Rukletsov and Xiaojian Huang. > > > Bugs: MESOS-4941 > https://issues.apache.org/jira/browse/MESOS-4941 > > > Repository: mesos > > > Description > ------- > > Added master API call for `UPDATE_QUOTA`. > > > Diffs > ----- > > include/mesos/master/master.proto 3553c683c17004ac1831ec90271aa8584c950e53 > include/mesos/v1/master/master.proto 022b491b7d5c49c5aeddf4ffc97c148f55629c95 > src/master/http.cpp 90cbed1ba411e18906fe9c26bc14576a26d1b7b9 > src/master/master.hpp b6c610b79aab146ece6b9be59be86f283d1c9ee8 > src/master/quota_handler.cpp 5578663f26d9b737499dc4f5a286c34c37645442 > src/master/validation.cpp 42d9b4a8784c2a161b74d7b46619cc22272e14e3 > src/tests/api_tests.cpp 8889e7807ecead736eaac3910332e86d594e8cec > > Diff: https://reviews.apache.org/r/53991/diff/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > > --===============6641543330043630843==--