From reviews-return-50671-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Nov 22 19:36:58 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6616E19F6D for ; Tue, 22 Nov 2016 19:36:58 +0000 (UTC) Received: (qmail 31665 invoked by uid 500); 22 Nov 2016 19:36:58 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 31637 invoked by uid 500); 22 Nov 2016 19:36:58 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 31613 invoked by uid 99); 22 Nov 2016 19:36:58 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Nov 2016 19:36:57 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A1BF82F5AAC; Tue, 22 Nov 2016 19:36:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4810262797528618772==" MIME-Version: 1.0 Subject: Re: Review Request 53877: Added temporary file environment passing towards docker. From: Till Toenshoff To: Kapil Arya , Jie Yu , Adam B , =?utf-8?q?Gast=C3=B3n_Kleiman?= , Joseph Wu Cc: Mesos ReviewBot , Till Toenshoff , mesos Date: Tue, 22 Nov 2016 19:36:56 -0000 Message-ID: <20161122193656.27388.26326@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Till Toenshoff X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53877/ X-Sender: Till Toenshoff References: <20161122184019.27388.36327@reviews.apache.org> In-Reply-To: <20161122184019.27388.36327@reviews.apache.org> Reply-To: Till Toenshoff X-ReviewRequest-Repository: mesos --===============4810262797528618772== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53877/ ----------------------------------------------------------- (Updated Nov. 22, 2016, 7:36 p.m.) Review request for mesos, Adam B, Gastón Kleiman, Jie Yu, Kapil Arya, and Joseph Wu. Changes ------- Smoothed code a little by use of temporary to prevent extra .get()'s. Bugs: MESOS-6566 https://issues.apache.org/jira/browse/MESOS-6566 Repository: mesos Description ------- see summary. Diffs (updated) ----- src/docker/docker.cpp f03ea7fa55e976e44282503261ac50e1502592a2 Diff: https://reviews.apache.org/r/53877/diff/ Testing ------- ``` $ make check ``` ``` $ ./src/mesos-execute --command="sleep 200" --containerizer=docker --docker_image=alpine --env='{"foo": "bar"}' --master=149.202.202.185:5050 ``` ``` $ ps aux root 27645 0.2 0.0 372852 30180 ? Sl 15:50 0:00 docker -H unix:///var/run/docker.sock run --cpu-shares 1024 --memory 134217728 --env-file /tmp/l53ILz/ktpuDS -v /tmp/mesos/slaves/91b671fd-3c83-425e-96c2-26ecdc410028-S0/frameworks/91b671fd-3c83-425e-96c2-26ecdc410028-0001/executors/test/runs/a75fc411-3d18-44f1-a562-9f759c281da0:/mnt/mesos/sandbox --net host --entrypoint /bin/sh --name mesos-91b671fd-3c83-425e-96c2-26ecdc410028-S0.a75fc411-3d18-44f1-a562-9f759c281da0 alpine -c sleep 200 ``` ``` $ more /tmp/l53ILz/ktpuDS foo=bar MESOS_SANDBOX=/mnt/mesos/sandbox MESOS_CONTAINER_NAME=mesos-91b671fd-3c83-425e-96c2-26ecdc410028-S0.a75fc411-3d18-44f1-a562-9f759c281da0 ``` Thanks, Till Toenshoff --===============4810262797528618772==--