From reviews-return-50563-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Nov 21 08:48:45 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B5F3319B4D for ; Mon, 21 Nov 2016 08:48:45 +0000 (UTC) Received: (qmail 40357 invoked by uid 500); 21 Nov 2016 08:48:45 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 40328 invoked by uid 500); 21 Nov 2016 08:48:45 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 40303 invoked by uid 99); 21 Nov 2016 08:48:44 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Nov 2016 08:48:44 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6CE7A1C01D5; Mon, 21 Nov 2016 08:48:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4835561723728229341==" MIME-Version: 1.0 Subject: Re: Review Request 53837: Added a per container io switchboard server process. From: Kevin Klues To: Jie Yu , Vinod Kone , Benjamin Hindman Cc: Mesos ReviewBot , Kevin Klues , =?utf-8?q?Gast=C3=B3n_Kleiman?= , mesos Date: Mon, 21 Nov 2016 08:48:43 -0000 Message-ID: <20161121084843.27388.60365@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Kevin Klues X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53837/ X-Sender: Kevin Klues References: <20161120230211.27388.47551@reviews.apache.org> In-Reply-To: <20161120230211.27388.47551@reviews.apache.org> X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/io_switchboard/io_switchboard.hpp X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/io_switchboard/io_switchboard.cpp X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/io_switchboard/main.hpp X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/io_switchboard/main.cpp Reply-To: Kevin Klues X-ReviewRequest-Repository: mesos --===============4835561723728229341== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53837/ ----------------------------------------------------------- (Updated Nov. 21, 2016, 8:48 a.m.) Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone. Changes ------- Updated to do proepr accept() loop and (nor now) added environment variables for LIBPROCESS_IP/PORT since we end up starting an HTTP server for the `send()` calls we make between the `OputputWriters` and the `SwitchboardServer`. Bugs: MESOS-6467 https://issues.apache.org/jira/browse/MESOS-6467 Repository: mesos Description ------- Currently, this process simply intercepts the stdout/stderr of a container and writes it to the stdout/stderr FDs set up by the container logger. We also send the stdout/stderr data to a simple HTTP server that we launch on a unix domain socket set up by the agent. Right now this server is just a stub and doesn't do anything useful. In future commits, we will expand this HTTP server to handle 'ATTACH_CONTAINER_INPUT' and 'ATTACH_CONTAINER_OUTPUT' calls on behalf of a container. It will use the stdout/stderr messages passed to it to and send that data over the response stream to any clients connected with an 'ATTACH_CONTAINER_OUTPUT' call. Likewise, it will take any input streamed in over a 'ATTACH_CONTAINER_INPUT' request and write it to a container's stdin. We don't currently handle recovering access to the io switchboard server process after agent restarts. We will add that in a subsequent commit. Diffs (updated) ----- src/Makefile.am 5a47c93388234a68c3c486a021ccdbe3213c5bac src/slave/containerizer/mesos/containerizer.cpp ec4ae32485a7ab6c9f73c512004d1220482a188e src/slave/containerizer/mesos/io_switchboard/io_switchboard.hpp PRE-CREATION src/slave/containerizer/mesos/io_switchboard/io_switchboard.cpp PRE-CREATION src/slave/containerizer/mesos/io_switchboard/main.hpp PRE-CREATION src/slave/containerizer/mesos/io_switchboard/main.cpp PRE-CREATION Diff: https://reviews.apache.org/r/53837/diff/ Testing ------- GTEST_FILTER="" make -j check sudo src/mesos-tests Thanks, Kevin Klues --===============4835561723728229341==--