From reviews-return-50505-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sat Nov 19 09:47:28 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C2F8719E59 for ; Sat, 19 Nov 2016 09:47:28 +0000 (UTC) Received: (qmail 99849 invoked by uid 500); 19 Nov 2016 09:47:28 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 99817 invoked by uid 500); 19 Nov 2016 09:47:28 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 99793 invoked by uid 99); 19 Nov 2016 09:47:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 19 Nov 2016 09:47:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2BA641C0424; Sat, 19 Nov 2016 09:47:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2133846947614087339==" MIME-Version: 1.0 Subject: Re: Review Request 52873: Cleaned up private members in HealthChecker class. From: Benjamin Mahler To: =?utf-8?q?Gast=C3=B3n_Kleiman?= , haosdent huang Cc: Benjamin Mahler , Alexander Rukletsov , mesos Date: Sat, 19 Nov 2016 09:47:26 -0000 Message-ID: <20161119094726.20485.38355@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Mahler X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/52873/ X-Sender: Benjamin Mahler X-ReviewBoard-ShipIt: 1 References: <20161114103056.20485.50290@reviews.apache.org> In-Reply-To: <20161114103056.20485.50290@reviews.apache.org> Reply-To: Benjamin Mahler X-ReviewRequest-Repository: mesos --===============2133846947614087339== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52873/#review156395 ----------------------------------------------------------- Ship it! src/health-check/health_checker.hpp (line 141) Maybe instead a comment on why we need the launcher dir? - Benjamin Mahler On Nov. 14, 2016, 10:30 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52873/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2016, 10:30 a.m.) > > > Review request for mesos, Gastón Kleiman and haosdent huang. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/health-check/health_checker.hpp a1dc72493ff31b87068d5691f4d5b794392caf76 > src/health-check/health_checker.cpp e2b32e2d57515202f547d12ba492ad8eb633641b > > Diff: https://reviews.apache.org/r/52873/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rukletsov > > --===============2133846947614087339==--