From reviews-return-50424-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Nov 18 16:05:26 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D70D819064 for ; Fri, 18 Nov 2016 16:05:26 +0000 (UTC) Received: (qmail 93261 invoked by uid 500); 18 Nov 2016 16:05:26 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 93234 invoked by uid 500); 18 Nov 2016 16:05:26 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 93207 invoked by uid 99); 18 Nov 2016 16:05:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Nov 2016 16:05:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0E5AB1CC185; Fri, 18 Nov 2016 16:05:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8644837019252189875==" MIME-Version: 1.0 Subject: Re: Review Request 53877: Added temporary file environment passing towards docker. From: Mesos ReviewBot To: Jie Yu , Adam B , =?utf-8?q?Gast=C3=B3n_Kleiman?= , Joseph Wu Cc: Mesos ReviewBot , Till Toenshoff , mesos Date: Fri, 18 Nov 2016 16:05:25 -0000 Message-ID: <20161118160525.20485.6245@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos ReviewBot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53877/ X-Sender: Mesos ReviewBot References: <20161118153918.20485.5867@reviews.apache.org> In-Reply-To: <20161118153918.20485.5867@reviews.apache.org> Reply-To: Mesos ReviewBot X-ReviewRequest-Repository: mesos --===============8644837019252189875== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53877/#review156303 ----------------------------------------------------------- Bad patch! Reviews applied: [53877] Failed command: ./support/apply-review.sh -n -r 53877 Error: 2016-11-18 16:04:49 URL:https://reviews.apache.org/r/53877/diff/raw/ [3053/3053] -> "53877.patch" [1] error: patch failed: src/docker/docker.cpp:532 error: src/docker/docker.cpp: patch does not apply Full log: https://builds.apache.org/job/mesos-reviewbot/16117/console - Mesos ReviewBot On Nov. 18, 2016, 3:39 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53877/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2016, 3:39 p.m.) > > > Review request for mesos, Adam B, Gastón Kleiman, Jie Yu, and Joseph Wu. > > > Bugs: MESOS-6566 > https://issues.apache.org/jira/browse/MESOS-6566 > > > Repository: mesos > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/docker/docker.cpp 50fda39 > > Diff: https://reviews.apache.org/r/53877/diff/ > > > Testing > ------- > > ``` > $ make check > ``` > > ``` > $ ./src/mesos-execute --command="sleep 200" --containerizer=docker --docker_image=alpine --env='{"foo": "bar"}' --master=149.202.202.185:5050 > ``` > > ``` > $ ps aux > root 27645 0.2 0.0 372852 30180 ? Sl 15:50 0:00 docker -H unix:///var/run/docker.sock run --cpu-shares 1024 --memory 134217728 --env-file /tmp/l53ILz/ktpuDS -v /tmp/mesos/slaves/91b671fd-3c83-425e-96c2-26ecdc410028-S0/frameworks/91b671fd-3c83-425e-96c2-26ecdc410028-0001/executors/test/runs/a75fc411-3d18-44f1-a562-9f759c281da0:/mnt/mesos/sandbox --net host --entrypoint /bin/sh --name mesos-91b671fd-3c83-425e-96c2-26ecdc410028-S0.a75fc411-3d18-44f1-a562-9f759c281da0 alpine -c sleep 200 > ``` > > ``` > $ more /tmp/l53ILz/ktpuDS > foo=bar > MESOS_SANDBOX=/mnt/mesos/sandbox > MESOS_CONTAINER_NAME=mesos-91b671fd-3c83-425e-96c2-26ecdc410028-S0.a75fc411-3d18-44f1-a562-9f759c281da0 > ``` > > > Thanks, > > Till Toenshoff > > --===============8644837019252189875==--