From reviews-return-50389-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Nov 17 21:05:32 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0400F191A3 for ; Thu, 17 Nov 2016 21:05:32 +0000 (UTC) Received: (qmail 13358 invoked by uid 500); 17 Nov 2016 21:05:31 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 13328 invoked by uid 500); 17 Nov 2016 21:05:31 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 13307 invoked by uid 99); 17 Nov 2016 21:05:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Nov 2016 21:05:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9469D1CF890; Thu, 17 Nov 2016 21:05:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4220540479136871452==" MIME-Version: 1.0 Subject: Re: Review Request 52886: Fix new sign comparison errors in stout produced by hardened flags From: Michael Park To: Neil Conway , Michael Park , James Peach Cc: Aaron Wood , mesos Date: Thu, 17 Nov 2016 21:05:30 -0000 Message-ID: <20161117210530.20484.51904@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Michael Park X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/52886/ X-Sender: Michael Park X-ReviewBoard-ShipIt: 1 References: <20161108173955.4232.84794@reviews.apache.org> In-Reply-To: <20161108173955.4232.84794@reviews.apache.org> Reply-To: Michael Park X-ReviewRequest-Repository: mesos --===============4220540479136871452== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52886/#review156240 ----------------------------------------------------------- Fix it, then Ship it! 3rdparty/stout/tests/json_tests.cpp (line 196) This should stay as `7` I think? - Michael Park On Nov. 8, 2016, 9:39 a.m., Aaron Wood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52886/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2016, 9:39 a.m.) > > > Review request for mesos, James Peach, Michael Park, and Neil Conway. > > > Bugs: MESOS-6239 > https://issues.apache.org/jira/browse/MESOS-6239 > > > Repository: mesos > > > Description > ------- > > The hardening flags produced many new sign comparison errors in stout that need to be fixed for Mesos to compile/run. > > > Diffs > ----- > > 3rdparty/stout/tests/cache_tests.cpp 0950c85 > 3rdparty/stout/tests/flags_tests.cpp da4deb9 > 3rdparty/stout/tests/hashmap_tests.cpp 2626d67 > 3rdparty/stout/tests/hashset_tests.cpp 66e59db > 3rdparty/stout/tests/ip_tests.cpp b5a206f > 3rdparty/stout/tests/json_tests.cpp 2bc4c88 > 3rdparty/stout/tests/linkedhashmap_tests.cpp 7a80769 > 3rdparty/stout/tests/multimap_tests.cpp 488991b > 3rdparty/stout/tests/os/process_tests.cpp 4cb3b5f > 3rdparty/stout/tests/os/sendfile_tests.cpp e221689 > 3rdparty/stout/tests/os/systems_tests.cpp 110ba5b > 3rdparty/stout/tests/os_tests.cpp 0b7ee07 > 3rdparty/stout/tests/strings_tests.cpp 7dd3301 > > Diff: https://reviews.apache.org/r/52886/diff/ > > > Testing > ------- > > Made sure compilation, tests, and benchmarks worked with both gcc and clang. Ran make && make check && make bench. > > > Thanks, > > Aaron Wood > > --===============4220540479136871452==--