From reviews-return-50359-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Nov 17 06:52:35 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 10EF819073 for ; Thu, 17 Nov 2016 06:52:35 +0000 (UTC) Received: (qmail 72771 invoked by uid 500); 17 Nov 2016 06:52:35 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 72741 invoked by uid 500); 17 Nov 2016 06:52:34 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 72720 invoked by uid 99); 17 Nov 2016 06:52:34 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Nov 2016 06:52:34 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id ACAA91CF890; Thu, 17 Nov 2016 06:52:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4331746757781940440==" MIME-Version: 1.0 Subject: Review Request 53841: Added metrics for sorting of the sorters in the allocator. From: Anindya Sinha To: Jiang Yan Xu Cc: Anindya Sinha , mesos Date: Thu, 17 Nov 2016 06:52:33 -0000 Message-ID: <20161117065233.20484.27705@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Anindya Sinha X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53841/ X-Sender: Anindya Sinha Reply-To: Anindya Sinha X-ReviewRequest-Repository: mesos --===============4331746757781940440== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53841/ ----------------------------------------------------------- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-6579 https://issues.apache.org/jira/browse/MESOS-6579 Repository: mesos Description ------- Following metrics have been added: a) allocator/mesos/roles/sort_runs: Number of role/quota level sorts in DRF Sorter. b) allocator/mesos/roles/sort_run: Latency in role/quota level sorts in DRF Sorter. c) allocator/mesos/frameworks/sort_runs: Number of framework level sorts (across all roles) in DRF Sorter. d) allocator/mesos/frameworks/sort_run: Latency in framework level sorts (across all roles) in DRF Sorter. Diffs ----- src/master/allocator/mesos/hierarchical.cpp c8f9492ee1b69e125a1e841116d22a578a9b524e src/master/allocator/mesos/metrics.hpp 753f90acc52ada84883cbbe3350e61d1e1eaff48 src/master/allocator/mesos/metrics.cpp a36d21c297160bc1c9f43a22743fd5448d7ae5ac src/tests/hierarchical_allocator_tests.cpp edd5cea8996d7c616cf9428f0f1c05d70c37c307 Diff: https://reviews.apache.org/r/53841/diff/ Testing ------- All tests passed. Thanks, Anindya Sinha --===============4331746757781940440==--