----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53475/#review156173 ----------------------------------------------------------- Patch looks great! Reviews applied: [53474, 53475] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Nov. 16, 2016, 10:27 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53475/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2016, 10:27 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-6520 > https://issues.apache.org/jira/browse/MESOS-6520 > > > Repository: mesos > > > Description > ------- > > Pass the error code down to the Error object explicitly, rather than > setting the per-thread error and using it implicitly. > > > Diffs > ----- > > 3rdparty/libprocess/src/libevent_ssl_socket.cpp 21f878ee81db32ad35878ec053c3f2de3637196c > 3rdparty/libprocess/src/poll_socket.cpp f0ee1490e6fccb038f64a27b2c71458ad5b5e5a1 > > Diff: https://reviews.apache.org/r/53475/diff/ > > > Testing > ------- > > make check on Fedora 24 > > > Thanks, > > James Peach > >