----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/#review156151 ----------------------------------------------------------- 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp (line 33) `s/adaptor/translator/` 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp (lines 36 - 38) What are these for? 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp (line 148) What is `NONE` for? it doesn't seem like we use it? 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp (lines 356 - 379) Do we actually need this for something..? 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp (lines 416 - 440) What is this used for? - Michael Park On Nov. 16, 2016, 10:37 a.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52544/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2016, 10:37 a.m.) > > > Review request for mesos, Alex Naparu, Alex Clemmer, Joseph Wu, and Michael Park. > > > Repository: mesos > > > Description > ------- > > In POSIX the `socket`,`pipe` and the `filedescriptor` are > represented by an int type. In Windows a socket is kept in a > `SOCKET` type (64 bit wide), a pipe in a `HANDLE` (64 bit wide) and > a file descriptor in an int. This class unifies all Windows types. > In POSIX this class is an int. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os.hpp bd085e4e29bbdb2d2baaaeff1d10c0bd95ca65ba > 3rdparty/stout/include/stout/os/filedescriptor.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/52544/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Pravat > >