From reviews-return-50279-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Nov 16 01:24:36 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B962E19983 for ; Wed, 16 Nov 2016 01:24:36 +0000 (UTC) Received: (qmail 83263 invoked by uid 500); 16 Nov 2016 01:24:36 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 83230 invoked by uid 500); 16 Nov 2016 01:24:36 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 83204 invoked by uid 99); 16 Nov 2016 01:24:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Nov 2016 01:24:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A4FD12D7E62; Wed, 16 Nov 2016 01:24:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3236196594233116344==" MIME-Version: 1.0 Subject: Review Request 53804: Added a parameter to 'Socket::shutdown' to specify 'how'. From: Greg Mann To: Benjamin Mahler , Joseph Wu Cc: Greg Mann , mesos Date: Wed, 16 Nov 2016 01:24:35 -0000 Message-ID: <20161116012435.20484.5149@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53804/ X-Sender: Greg Mann Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============3236196594233116344== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53804/ ----------------------------------------------------------- Review request for mesos, Benjamin Mahler and Joseph Wu. Bugs: MESOS-5658 https://issues.apache.org/jira/browse/MESOS-5658 Repository: mesos Description ------- This patch adds a parameter to the `Socket::shutdown` function which allows callers to specify whether they would like the read end, write end, or both ends of the socket to be shutdown. Diffs ----- 3rdparty/libprocess/include/process/socket.hpp f798af7879546d71e8ef4a295c9cf489a70cb61f Diff: https://reviews.apache.org/r/53804/diff/ Testing ------- Testing details are found at the end of this review chain. Thanks, Greg Mann --===============3236196594233116344==--