From reviews-return-50019-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Nov 11 10:25:01 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 00321197F4 for ; Fri, 11 Nov 2016 10:25:01 +0000 (UTC) Received: (qmail 7207 invoked by uid 500); 11 Nov 2016 10:25:00 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 7178 invoked by uid 500); 11 Nov 2016 10:25:00 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 7134 invoked by uid 99); 11 Nov 2016 10:25:00 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Nov 2016 10:25:00 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EC4861CC36F; Fri, 11 Nov 2016 10:24:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2973236247113707978==" MIME-Version: 1.0 Subject: Re: Review Request 53645: Added '--task' into mesos-execute. From: Mesos ReviewBot To: Jie Yu , Avinash sridharan , Vinod Kone Cc: Mesos ReviewBot , Qian Zhang , mesos Date: Fri, 11 Nov 2016 10:24:59 -0000 Message-ID: <20161111102459.1690.90787@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos ReviewBot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53645/ X-Sender: Mesos ReviewBot References: <20161111031312.1690.77415@reviews.apache.org> In-Reply-To: <20161111031312.1690.77415@reviews.apache.org> Reply-To: Mesos ReviewBot X-ReviewRequest-Repository: mesos --===============2973236247113707978== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53645/#review155701 ----------------------------------------------------------- Patch looks great! Reviews applied: [53644, 53645] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Nov. 11, 2016, 3:13 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53645/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2016, 3:13 a.m.) > > > Review request for mesos, Avinash sridharan, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-6571 > https://issues.apache.org/jira/browse/MESOS-6571 > > > Repository: mesos > > > Description > ------- > > Added '--task' into mesos-execute. > > > Diffs > ----- > > src/cli/execute.cpp b47c427c5ad29dda1985ee8fef6c4efe054df879 > > Diff: https://reviews.apache.org/r/53645/diff/ > > > Testing > ------- > > On Ubuntu 16.04, manually ran the command below to successfuly launch a container which will be attached to a CNI network "net1". > ``` > # sudo src/mesos-execute --master=192.168.122.216:5050 --task=file:///home/stack/workspace/mesos/build/task.json > > # cat /home/stack/workspace/mesos/build/task.json > { > "name": "test", > "task_id": {"value" : "test"}, > "agent_id": {"value" : ""}, > "resources": [ > { > "name": "cpus", > "type": "SCALAR", > "scalar": { > "value": 0.1 > }, > "role": "*" > }, > { > "name": "mem", > "type": "SCALAR", > "scalar": { > "value": 32 > }, > "role": "*" > } > ], > "command": { > "value": "ifconfig" > }, > "container": { > "type": "MESOS", > "mesos": { > "image": { > "type": "DOCKER", > "docker": { > "name": "busybox" > } > } > }, > "network_infos": [ > { > "name": "net1" > } > ] > } > } > ``` > > > Thanks, > > Qian Zhang > > --===============2973236247113707978==--