From reviews-return-49970-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Nov 10 17:53:23 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8CBB3195A5 for ; Thu, 10 Nov 2016 17:53:23 +0000 (UTC) Received: (qmail 462 invoked by uid 500); 10 Nov 2016 17:53:23 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 437 invoked by uid 500); 10 Nov 2016 17:53:23 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 417 invoked by uid 99); 10 Nov 2016 17:53:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Nov 2016 17:53:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6641025BF59; Thu, 10 Nov 2016 17:53:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4749545596257763020==" MIME-Version: 1.0 Subject: Re: Review Request 53627: Implement a namespaces/uts isolator. From: James Peach To: Jie Yu Cc: James Peach , mesos Date: Thu, 10 Nov 2016 17:53:21 -0000 Message-ID: <20161110175321.1691.85797@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: James Peach X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53627/ X-Sender: James Peach References: <20161109221532.724.12418@reviews.apache.org> In-Reply-To: <20161109221532.724.12418@reviews.apache.org> X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/namespaces/uts.cpp X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/namespaces/uts.hpp Reply-To: James Peach X-ReviewRequest-Repository: mesos --===============4749545596257763020== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53627/ ----------------------------------------------------------- (Updated Nov. 10, 2016, 5:53 p.m.) Review request for mesos and Jie Yu. Bugs: MESOS-6556 https://issues.apache.org/jira/browse/MESOS-6556 Repository: mesos Description ------- Implement a very simple namespaces/uts isolator that can be used to set the hostname and domainname of a container without the necessity of a CNI plugin. Since we already had a `hostname` field in the ContainerInfo, we can use that to set the host name once we are in the UTS namespace. Add a corresponding `domainname` to the ContainerInfo to allow setting the domain name. Diffs (updated) ----- include/mesos/mesos.proto 380575904a5a29ee53bdc87ae8791ed14e3cafca include/mesos/slave/containerizer.proto f4c4ad771b5dead4ea3ee7cd1b4383c4dc2359b4 src/Makefile.am 5a47c93388234a68c3c486a021ccdbe3213c5bac src/cli/execute.cpp b47c427c5ad29dda1985ee8fef6c4efe054df879 src/slave/containerizer/mesos/containerizer.cpp 44225ebf63d8dd93be9b60fff496c74dc6c3a5ad src/slave/containerizer/mesos/isolators/namespaces/uts.hpp PRE-CREATION src/slave/containerizer/mesos/isolators/namespaces/uts.cpp PRE-CREATION src/slave/containerizer/mesos/launch.hpp 8b23c1b6df6bc1fdd987af5a4469664356e7f27a src/slave/containerizer/mesos/launch.cpp 377a9d94aa780ab598b1c2034c10ce25a4e02cbe src/tests/containerizer/isolator_tests.cpp 8fefeef8c83ed2ab01f56a1ec572d3acb307143c Diff: https://reviews.apache.org/r/53627/diff/ Testing ------- make check. Thanks, James Peach --===============4749545596257763020==--