From reviews-return-49967-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Nov 10 17:46:33 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DB37519566 for ; Thu, 10 Nov 2016 17:46:33 +0000 (UTC) Received: (qmail 81738 invoked by uid 500); 10 Nov 2016 17:46:33 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 81710 invoked by uid 500); 10 Nov 2016 17:46:33 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 81683 invoked by uid 99); 10 Nov 2016 17:46:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Nov 2016 17:46:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 214CD25BF59; Thu, 10 Nov 2016 17:46:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7593075255108711267==" MIME-Version: 1.0 Subject: Re: Review Request 53624: Use JSON content type in mesos-execute. From: James Peach To: Anand Mazumdar , Jie Yu , Vinod Kone Cc: Mesos ReviewBot , James Peach , mesos Date: Thu, 10 Nov 2016 17:46:33 -0000 Message-ID: <20161110174633.1690.45180@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: James Peach X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53624/ X-Sender: James Peach References: <20161109215909.724.15858@reviews.apache.org> In-Reply-To: <20161109215909.724.15858@reviews.apache.org> Reply-To: James Peach X-ReviewRequest-Repository: mesos --===============7593075255108711267== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53624/ ----------------------------------------------------------- (Updated Nov. 10, 2016, 5:46 p.m.) Review request for mesos, Anand Mazumdar, Jie Yu, and Vinod Kone. Changes ------- Add `--json` flag. Bugs: MESOS-6562 https://issues.apache.org/jira/browse/MESOS-6562 Repository: mesos Description ------- Use JSON content type in mesos-execute so that packet tracing protocol interactions is easier. Diffs (updated) ----- src/cli/execute.cpp b47c427c5ad29dda1985ee8fef6c4efe054df879 Diff: https://reviews.apache.org/r/53624/diff/ Testing ------- make check. Manually verified with tcpdump. Thanks, James Peach --===============7593075255108711267==--