From reviews-return-49754-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Nov 7 19:31:30 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D0591196BA for ; Mon, 7 Nov 2016 19:31:30 +0000 (UTC) Received: (qmail 99712 invoked by uid 500); 7 Nov 2016 19:31:30 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 99682 invoked by uid 500); 7 Nov 2016 19:31:30 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 99658 invoked by uid 99); 7 Nov 2016 19:31:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Nov 2016 19:31:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8B1CA2D79AE; Mon, 7 Nov 2016 19:31:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9110303238248559009==" MIME-Version: 1.0 Subject: Re: Review Request 53465: Fixed the container status for nested containers. From: Vinod Kone To: Kevin Klues , Vinod Kone Cc: Jie Yu , mesos Date: Mon, 07 Nov 2016 19:31:29 -0000 Message-ID: <20161107193129.4232.33674@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Vinod Kone X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53465/ X-Sender: Vinod Kone X-ReviewBoard-ShipIt: 1 References: <20161104070717.31640.46905@reviews.apache.org> In-Reply-To: <20161104070717.31640.46905@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Vinod Kone X-ReviewRequest-Repository: mesos --===============9110303238248559009== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53465/#review155188 ----------------------------------------------------------- Ship it! Ship It! - Vinod Kone On Nov. 4, 2016, 7:07 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53465/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2016, 7:07 a.m.) > > > Review request for mesos, Kevin Klues and Vinod Kone. > > > Bugs: MESOS-6465 and MESOS-6528 > https://issues.apache.org/jira/browse/MESOS-6465 > https://issues.apache.org/jira/browse/MESOS-6528 > > > Repository: mesos > > > Description > ------- > > Prior to this patch, the ContainerStatus inside the TaskStatus for a > task in the default executor is not correct. The agent always gets the > container status of the top level container, even if the task might > correspond to a nested container. > > This patch fixed this issue by letting the executor set the container > ID for the task (because only it has the knowledge about this > mapping), and the agent will use that container ID to get the proper > container status. > > > Diffs > ----- > > src/launcher/default_executor.cpp b8a88ad6e361720dc7d02c9423db3e67226f779f > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 2f6723c64261fb3295626d6479fe844fb23b0650 > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 939142e36b926d9e4201d35dedd25e32e9f8c63c > src/slave/slave.cpp d6c337345707993b0729e9eaf36b5a9ecc52dc72 > > Diff: https://reviews.apache.org/r/53465/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > > --===============9110303238248559009==--