From reviews-return-49618-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sat Nov 5 00:44:14 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4DFF81977B for ; Sat, 5 Nov 2016 00:44:14 +0000 (UTC) Received: (qmail 9990 invoked by uid 500); 5 Nov 2016 00:44:14 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 9961 invoked by uid 500); 5 Nov 2016 00:44:14 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 9946 invoked by uid 99); 5 Nov 2016 00:44:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 05 Nov 2016 00:44:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6FDED2DD064; Sat, 5 Nov 2016 00:44:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8153411813157764555==" MIME-Version: 1.0 Subject: =?utf-8?q?Review_Request_53509=3A_Flag_=E2=80=94master_now_required_and_p?= =?utf-8?q?arsed_by_MasterDetector=2E?= From: Armand Grillet To: Armand Grillet , mesos Date: Sat, 05 Nov 2016 00:44:13 -0000 Message-ID: <20161105004413.31640.42477@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Armand Grillet X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53509/ X-Sender: Armand Grillet Reply-To: Armand Grillet X-ReviewRequest-Repository: mesos --===============8153411813157764555== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53509/ ----------------------------------------------------------- Review request for mesos. Bugs: MESOS-2723 https://issues.apache.org/jira/browse/MESOS-2723 Repository: mesos Description ------- This commit makes the —master argument mandatory. The parsing of the argument now happens in src/master/detector.cpp. Diffs ----- src/cli/execute.cpp b265bc6390ed8329a200408ef45512f900f9b999 Diff: https://reviews.apache.org/r/53509/diff/ Testing ------- Testing done by running a master with `--zk=zk://localhost:2181/mesos` then an agent with `--master=zk://localhost:2181/mesos` and then executing a sleep task on Mesos with `--master=zk://localhost:2181/mesos`. Thanks, Armand Grillet --===============8153411813157764555==--