From reviews-return-49524-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Nov 4 14:22:40 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2AC2E1937A for ; Fri, 4 Nov 2016 14:22:40 +0000 (UTC) Received: (qmail 80918 invoked by uid 500); 4 Nov 2016 14:22:40 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 80890 invoked by uid 500); 4 Nov 2016 14:22:40 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 80868 invoked by uid 99); 4 Nov 2016 14:22:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Nov 2016 14:22:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 72E902DCEEF; Fri, 4 Nov 2016 14:22:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6988122765665744484==" MIME-Version: 1.0 Subject: Re: Review Request 53467: Added ContainerStatus.container_id to JSON endpoints. From: Mesos ReviewBot To: Kevin Klues , Vinod Kone Cc: Mesos ReviewBot , Jie Yu , mesos Date: Fri, 04 Nov 2016 14:22:39 -0000 Message-ID: <20161104142239.31640.61556@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos ReviewBot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53467/ X-Sender: Mesos ReviewBot References: <20161104074044.31640.82640@reviews.apache.org> In-Reply-To: <20161104074044.31640.82640@reviews.apache.org> Reply-To: Mesos ReviewBot X-ReviewRequest-Repository: mesos --===============6988122765665744484== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53467/#review154903 ----------------------------------------------------------- Patch looks great! Reviews applied: [53463, 53464, 53465, 53466, 53467] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Nov. 4, 2016, 7:40 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53467/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2016, 7:40 a.m.) > > > Review request for mesos, Kevin Klues and Vinod Kone. > > > Bugs: MESOS-6465 and MESOS-6528 > https://issues.apache.org/jira/browse/MESOS-6465 > https://issues.apache.org/jira/browse/MESOS-6528 > > > Repository: mesos > > > Description > ------- > > Added ContainerStatus.container_id to JSON endpoints. > > > Diffs > ----- > > src/common/http.hpp c2398177c9e5af12c7a20c02e92d3f3036a7a39a > src/common/http.cpp fb8454a97ad78c306d17b4222c14d68b3598175d > src/slave/http.cpp a32aca437cffd52bc2bcde859eedddca2038e3f1 > src/tests/slave_tests.cpp 8f1dbef081171421bf2761e24a4f267cbd015d0d > > Diff: https://reviews.apache.org/r/53467/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > > --===============6988122765665744484==--