From reviews-return-49426-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Nov 3 17:10:20 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0128319209 for ; Thu, 3 Nov 2016 17:10:20 +0000 (UTC) Received: (qmail 58218 invoked by uid 500); 3 Nov 2016 17:10:19 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 58191 invoked by uid 500); 3 Nov 2016 17:10:19 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 58171 invoked by uid 99); 3 Nov 2016 17:10:19 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Nov 2016 17:10:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 57DED2DC937; Thu, 3 Nov 2016 17:10:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5960518065994467829==" MIME-Version: 1.0 Subject: Review Request 53437: Fix stout build option argument handling. From: James Peach To: James Peach , mesos Date: Thu, 03 Nov 2016 17:10:19 -0000 Message-ID: <20161103171019.1746.4113@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: James Peach X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53437/ X-Sender: James Peach Reply-To: James Peach X-ReviewRequest-Repository: mesos --===============5960518065994467829== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53437/ ----------------------------------------------------------- Review request for mesos. Repository: mesos Description ------- Fix all the AC_ARG_ENABLED options to correctly handle --enable-foo and --disable-foo variants. Update all the invocations to have a consistent calling convention. Diffs ----- 3rdparty/stout/configure.ac cbb0fdb0e1584ace7bbd6bf496f0f55b9846ce0b Diff: https://reviews.apache.org/r/53437/diff/ Testing ------- Thanks, James Peach --===============5960518065994467829==--