From reviews-return-49244-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Nov 2 08:20:33 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 07C25198A5 for ; Wed, 2 Nov 2016 08:20:33 +0000 (UTC) Received: (qmail 17109 invoked by uid 500); 2 Nov 2016 08:20:32 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 17085 invoked by uid 500); 2 Nov 2016 08:20:32 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 17052 invoked by uid 99); 2 Nov 2016 08:20:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Nov 2016 08:20:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9BF172D0D39; Wed, 2 Nov 2016 08:20:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1787523583436404607==" MIME-Version: 1.0 Subject: Re: Review Request 53366: Introduced a streaming gzip::Decompressor. From: Mesos ReviewBot To: Anand Mazumdar Cc: Mesos ReviewBot , Benjamin Mahler , mesos Date: Wed, 02 Nov 2016 08:20:31 -0000 Message-ID: <20161102082031.1745.33005@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos ReviewBot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53366/ X-Sender: Mesos ReviewBot References: <20161102030240.4874.22220@reviews.apache.org> In-Reply-To: <20161102030240.4874.22220@reviews.apache.org> Reply-To: Mesos ReviewBot X-ReviewRequest-Repository: mesos --===============1787523583436404607== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53366/#review154523 ----------------------------------------------------------- Patch looks great! Reviews applied: [53365, 53366] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Nov. 2, 2016, 3:02 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53366/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2016, 3:02 a.m.) > > > Review request for mesos and Anand Mazumdar. > > > Bugs: MESOS-6530 > https://issues.apache.org/jira/browse/MESOS-6530 > > > Repository: mesos > > > Description > ------- > > This enables incremental decompression of compressed input. > > > Diffs > ----- > > 3rdparty/stout/include/stout/gzip.hpp b78a8a31204ee585f8e4a88eaefe7346faa46b8d > 3rdparty/stout/tests/gzip_tests.cpp 814fb99da193cf950ba48817824acdabda2c2dfc > > Diff: https://reviews.apache.org/r/53366/diff/ > > > Testing > ------- > > Wrote a test for decompressing a byte at a time. Also ran this test manually with random chunk sizes. > > > Thanks, > > Benjamin Mahler > > --===============1787523583436404607==--