mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 51065: Changed hostname used for SSL cert creation in tests.
Date Wed, 30 Nov 2016 23:16:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51065/
-----------------------------------------------------------

(Updated Nov. 30, 2016, 11:16 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
-------

Rebase.


Bugs: MESOS-3753
    https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
-------

This changes the SSL helpers in libprocess to generate
certs using a hostname determined using the same address
that is advertised by libprocess. This assures that
validation of the certificates will succeed. The test
`SSLTest.BasicSameProcess` is also updated to accommodate
this change.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/ssl/gtest.hpp 2a19b3b1e09517151bddb43a128f45457da4ca8a

  3rdparty/libprocess/src/tests/ssl_tests.cpp 7fa46e4cc3e1225e9c9591fb5a1fb8d90c165c01 

Diff: https://reviews.apache.org/r/51065/diff/


Testing
-------

Testing details are found at the end of this chain.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message