mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 53802: Eliminated an EOF race condition in libprocess SSL socket.
Date Wed, 30 Nov 2016 23:12:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53802/
-----------------------------------------------------------

(Updated Nov. 30, 2016, 11:12 p.m.)


Review request for mesos, Benjamin Mahler and Joseph Wu.


Changes
-------

Rebase.


Bugs: MESOS-5966
    https://issues.apache.org/jira/browse/MESOS-5966


Repository: mesos


Description
-------

Previously, it was possible for an SSL socket to either:
1) Fail to receive an EOF if the EOF event was received when
   there was no pending recv() request.
2) Fail to receive all data sent on the sending side if an
   EOF event was received before all sent data was read.

This patch eliminates these race conditions to ensure reliable
receipt of both sent data and EOFs.


Diffs (updated)
-----

  3rdparty/libprocess/src/libevent_ssl_socket.hpp 57eaf4f607d0628db466cc1a139772eeeaa51136

  3rdparty/libprocess/src/libevent_ssl_socket.cpp dddd0e292a8b0d470f4e199db08f09a0c863d73c


Diff: https://reviews.apache.org/r/53802/diff/


Testing
-------

Testing details are found at the end of this chain.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message