mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Wood <>
Subject Re: Review Request 52696: Harden stout
Date Wed, 30 Nov 2016 20:50:56 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 30, 2016, 8:50 p.m.)

Review request for mesos, James Peach, Michael Park, and Neil Conway.


Don't warn when stack protection isn't used.

Bugs: MESOS-6229

Repository: mesos


Add hardened flags for stout.
Take compile flag macro at 391cb680171d3889965b1ead43d3a326c913bc25.
The macro at 1a869696e4129279f7b99c3f9052717354b79a86 requires autoconf 2.64 which breaks
on CentOS 6.

Diffs (updated)

  3rdparty/stout/ 4e10ae2 
  3rdparty/stout/ f071f61 
  3rdparty/stout/m4/ax_check_compile_flag.m4 PRE-CREATION 



Compared the benchmarks with and without the flags being used. Also did a comparsion with
the flags being used with and without optimizations and without the flags being used with
and without optimizations. Overall the performance hit was very small with a 3-8% overhead
(optimizations brings this down slightly). Most benchmarks were about 5% (or less) slower.

File Attachments

--enable-optimized with hardening applied
Hardening applied but no --enable-optimized
--enable-optimized with no hardening applied
No hardening applied and no --enable-optimized


Aaron Wood

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message