mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Review Request 54215: Fixed duplicate image layer ids returned by docker store.
Date Wed, 30 Nov 2016 18:54:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54215/
-----------------------------------------------------------

Review request for mesos, Artem Harutyunyan, Jie Yu, Qian Zhang, and Zhitao Li.


Bugs: MESOS-6654
    https://issues.apache.org/jira/browse/MESOS-6654


Repository: mesos


Description
-------

This issue is exposed by pulling the 'mesosphere/inky' docker
image using registry puller. Due to the duplicate layer id
from the manifest, there are duplicate layer pathes passed
to the backend. The aufs backend cannot handle this case and
returns 'invalid arguments' error. Ideally, we should make
sure that layer paths that are passed to the backend are
unique.


Diffs
-----

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 9dccd0673dbc0c61abfd4b88097f86e7d7131c46


Diff: https://reviews.apache.org/r/54215/diff/


Testing
-------

make check

Tested by the unit test `ROOT_CURL_INTERNET_DockerDefaultEntryptRegistryPuller`.

Manually tested using the `mesosphere/inky` image, which contains duplicate layer ids.


Thanks,

Gilbert Song


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message