mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 54035: Extended test coverage of posix/rlimits isolator.
Date Wed, 30 Nov 2016 14:42:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54035/#review157402
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/posix_rlimits_isolator_tests.cpp (line 134)
<https://reviews.apache.org/r/54035/#comment228001>

    Can we check the failure reason as well?



src/tests/containerizer/posix_rlimits_isolator_tests.cpp (line 144)
<https://reviews.apache.org/r/54035/#comment228003>

    Are we *sure* this is always `unlimited` and not `unbegrenzt` or alike :)



src/tests/containerizer/posix_rlimits_isolator_tests.cpp (line 202)
<https://reviews.apache.org/r/54035/#comment228002>

    See above on failure-reason.


- Till Toenshoff


On Nov. 23, 2016, 4:35 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54035/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2016, 4:35 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6402
>     https://issues.apache.org/jira/browse/MESOS-6402
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Extended test coverage of posix/rlimits isolator.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/posix_rlimits_isolator_tests.cpp 24b19d9eb1cc3e19f8325fbd76182837a5690581

> 
> Diff: https://reviews.apache.org/r/54035/diff/
> 
> 
> Testing
> -------
> 
> `make check` (OS X, clang trunk w/o optimizations)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message