-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53541/#review157387
-----------------------------------------------------------
Fix it, then Ship it!
Looks great! Just a few remaining nits.
src/tests/authorization_tests.cpp (line 2558)
<https://reviews.apache.org/r/53541/#comment227983>
s/execturos/executors/
src/tests/authorization_tests.cpp (lines 3144 - 3145)
<https://reviews.apache.org/r/53541/#comment227989>
"bar" can launch nested containers under executors running as linux user "bar"
src/tests/authorization_tests.cpp (line 3163)
<https://reviews.apache.org/r/53541/#comment227990>
s/execturos/executors/
src/tests/authorization_tests.cpp (lines 3233 - 3234)
<https://reviews.apache.org/r/53541/#comment227991>
s/no user in command/no command/
src/tests/authorization_tests.cpp (line 3376)
<https://reviews.apache.org/r/53541/#comment227992>
s/cannot/can/
- Adam B
On Nov. 29, 2016, 7:18 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53541/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2016, 7:18 a.m.)
>
>
> Review request for mesos, Adam B, Kapil Arya, Kevin Klues, and Till Toenshoff.
>
>
> Bugs: MESOS-6474
> https://issues.apache.org/jira/browse/MESOS-6474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Creates new authorization action for all the API's related to
> nested containers. This patch does not add the code necesary to
> call use those actions, this is done in a latter patch.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/acls.proto e3fd6a4a1b617a75714ebd6e08ab10cffa1a7d1b
> include/mesos/authorizer/authorizer.hpp 3cd0f84e25c0ea91a6f20eba26341a1b830d8cf2
> include/mesos/authorizer/authorizer.proto 0696a629ac2d2b9950e20708f0c3666b58ff7ca0
> src/authorizer/local/authorizer.cpp 77e05dd2475d6e7511e7c7eeea578ec31ff3d198
> src/tests/authorization_tests.cpp d23f551c2caa454da0c0f6cb7d77a8c2bd75a474
>
> Diff: https://reviews.apache.org/r/53541/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
|