mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 53974: Added support to handle ATTACH_CONTAINER_OUPUT in the io switchbaord.
Date Wed, 30 Nov 2016 03:51:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53974/
-----------------------------------------------------------

(Updated Nov. 30, 2016, 3:51 a.m.)


Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.


Changes
-------

Rebased on previous patch changes. Also updated to add a new flag for waiting until the iurst
connection comes before starting our redirect. Also updated to properly self terminate and
close all connections when the server is ready to shutdown. We self terminate in a way that
all outstanding messages in the event queue will be processed before we exit (thus ensuring
we flush the IO to any open connections). Also added a test to make sure this all works.


Bugs: MESOS-6467
    https://issues.apache.org/jira/browse/MESOS-6467


Repository: mesos


Description
-------

Added support to handle ATTACH_CONTAINER_OUPUT in the io switchbaord.


Diffs (updated)
-----

  src/slave/containerizer/mesos/io/switchboard.hpp aaa3a35245b291f6003f519dbf8c0e1b82bc15fd

  src/slave/containerizer/mesos/io/switchboard.cpp 25cbf2447d197134f0753b062b6f4130821005b2

  src/slave/containerizer/mesos/io/switchboard_main.cpp PRE-CREATION 
  src/tests/containerizer/io_switchboard_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/53974/diff/


Testing
-------

GTEST_FILTER="" make -j check
sudo src/mesos-tests


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message