mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 54148: Updated the io switchboard to launch an external io switchboard server.
Date Wed, 30 Nov 2016 03:48:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54148/
-----------------------------------------------------------

(Updated Nov. 30, 2016, 3:48 a.m.)


Review request for mesos and Jie Yu.


Changes
-------

Rebased on master. Also updated to use the new `run()` call semantics of the switchboard server.
Also moved the fd close() calls out of the parent hook on subprocess() and directly into the
parent.


Bugs: MESOS-6639
    https://issues.apache.org/jira/browse/MESOS-6639


Repository: mesos


Description
-------

We don't currently handle recovering access to the io switchboard
server process after agent restarts. We will add that in a subsequent
commit.


Diffs (updated)
-----

  src/Makefile.am d1cc1016b1642c504f52c27623bc12c7ddf07599 
  src/slave/containerizer/mesos/containerizer.cpp 4a03f97d10a1b34a0a13600af5ac6fc3679694fd

  src/slave/containerizer/mesos/io/switchboard.hpp aaa3a35245b291f6003f519dbf8c0e1b82bc15fd

  src/slave/containerizer/mesos/io/switchboard.cpp 25cbf2447d197134f0753b062b6f4130821005b2

  src/slave/containerizer/mesos/io/switchboard_main.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/54148/diff/


Testing
-------

GTEST_FILTER="" make -j check
sudo src/mesos-tests

[  FAILED  ] bool/UserContainerLoggerTest.ROOT_LOGROTATE_RotateWithSwitchUserTrueOrFalse/0,
where GetParam() = true


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message