mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Hindman <b...@berkeley.edu>
Subject Re: Review Request 54113: Added support for specifying how a socket should be shutdown.
Date Tue, 29 Nov 2016 20:15:45 GMT


> On Nov. 28, 2016, 6:25 p.m., Greg Mann wrote:
> > 3rdparty/libprocess/include/process/socket.hpp, lines 394-396
> > <https://reviews.apache.org/r/54113/diff/1/?file=1570964#file1570964line394>
> >
> >     BenM pointed out on my similar review that we need to alter our Windows headers
to map the POSIX constants `SHUT_WR` and `SHUT_RDWR` onto their Windows equivalents. Something
like this: https://reviews.apache.org/r/53990/

I'll commit your patch first, thanks Greg!


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54113/#review157083
-----------------------------------------------------------


On Nov. 28, 2016, 6:19 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54113/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2016, 6:19 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support for specifying how a socket should be shutdown.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/socket.hpp f798af7879546d71e8ef4a295c9cf489a70cb61f

> 
> Diff: https://reviews.apache.org/r/54113/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message